Good news thanks @mozzy @dkayiwa for this, so we have killed two birds with one stone, bundled spa-module all through with 2.3.1 platform running successfully
Sorry @sharif / @mozzy / @dkayiwa - I havenât followed all of the above, but there are some important bug fixes in 2.3.2-SNAPSHOT (eg. the latest in the 2.3.x branch).
Rather than bundle 2.3.1, we should be looking to cut a maintenance release of the 2.3 line and bundle 2.3.2 in the next distribution release.
@burke FYI
Mike
Looks ok to me .
cc @gcliff .can you do a minor release of Platform 2.3.2 ??
I assume â2.3.2-SNAPSHOTâ means the 2.3.x branch. Are there commits on that branch other than these bug fixes that would need to be reverted? @mozzyâs investigation suggests the primary issue with using Platform 2.3 for the RefApp 2.11 release was an assumption made in the standalone that 2.11 would be inheriting Platform 2.4 libraries (e.g., upgraded liquibase) and that has been reverted.
It is a maintenance branch, major changes like that are not included. We need this release to be made anyway, as all of our order-related functionality depends on it in our upcoming Rwanda release, due to bug fixes made. Whether the refapp chooses to use that or not is something I assume would have to come after some testing. But I would think this should be our default expectation, and should assume a maintenance release should be made, just like with nearly every module out there that we are including.
Mike
@burke , from the discussions above , i created a new standalone branch > openmrs-emr2_for_2.3.x thats compatible with platform 2.3.X where i reverted this change , so currently as long as reff app depends on 2.3.x ,
i confiured Bamboo to build the standalone from this branch openmrs-emr2_for_2.3.x , in otherwords its fine to depend on 2.3.2.
When reff app will be running on top of Platform 2.4.x , we shall configure bamboo to build the standalone from the usual branch > openmrs-emr2
I was trying to release Name Phonetics in preparation for the next Ref App release, but noticed that it didnât have a âReleaseâ job in Bamboo. So I cloned the one from Address Hierarchy, linked in the release scripts repo, and added the local release and development version variables, but itâs still not working⊠Iâm thinking Iâm forgetting how to link in the Github credentials:
https://ci.openmrs.org/browse/NP-NP-171/log
@dkayiwa @cintiadr can you remind me how this is done?
Thanks, Mark
The scm on the pom file needs to be ssh instead of https
I think this still complete https://wiki.openmrs.org/display/docs/Configuring+a+Plan+to+Release+from+Bamboo
hello @mozzy i would love to do the minor release though currently am in the middle of release process of 2.4.0-alpha
I wouldnât mind to help with a minor release of Platform 2.3.2 if its okay with you @mozzy
@jwnasambu , that would be my wish âŠ
Oh, duh, I should have looked for the wiki page instructions instead of fumbling my way through it.
Thanks @cintiadr, will try later today.
@mozzy when I check on this jira page, there are only 2 tickets to be released in 2.3.2 version. Could there be other tickets to be included in this release or its restricted?
Thanks @jwnasambu for this , these tickets were worked on this and this and probably closed may be if you are suggesting something different in the next platform 2.3.2 cc @gcliff
You are right! I have seen those tickets. my question is should I proceed with a release with only those 2 tickets or there are others to be added in this release?
N/B: its a community product and I wouldnât love to go a head without the community membersâ consent.
Sure you can go ahead, However i think you should confirm first with @gcliff about the progress of releasing 2.4.0-alpha and see whether its ok to go ahead
@jwnasambu the platform 2.4.0 is underway , am okay with u going on with the minor release, may be what would other senior devs in the community recommend ?
This is a very bright Idea. Thanks
@jwnasambu can you share the JIRA query that you used to come up with the two tickets?
Well, I wasnât the one who come up with the 2 tickets to be released. I simply went to the issue dashboard on jira - > clicked on the releases icon -> platform 2.3.2 and I found the two issues worked on and closed.