Add Unit tests and test data for Laboratory Handler

ivange94 · March 14, 2018, 10:30pm

What that means is that the code was not properly tested. It expects you to have that property set but never had any unit test to ensure this. Try specifying a value for that global property like it’s done here

github.com

openmrs/openmrs-module-radiology/blob/master/api/src/test/resources/org/openmrs/module/radiology/include/RadiologyOrderServiceComponentTestDataset.xml#L19


  Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS
  graphic logo is a trademark of OpenMRS Inc.


-->
<dataset>
<patient_identifier_type patient_identifier_type_id="1" name="Test Identifier Type" description="Test description" creator="1" date_created="2015-01-01 00:00:00.0" required="false" retired="false" uuid="0cbecb62-7249-4f91-8edf-d0206ecceb63"/>


<location location_id="1" name="Radiology Department" creator="1" date_created="2015-01-01 00:00:00.0" retired="false" uuid="c36006e5-9fbb-4f20-866b-0ece245615a1"/>


<!-- define the metadata for the Radiology Module -->
<global_property property="radiology.dicomUIDOrgRoot" property_value="2.25" description="DICOM UID org root component" datatype="org.openmrs.customdatatype.datatype.RegexValidatedTextDatatype" datatype_config="^[012]((\.0)|(\.[1-9]\d*))+$" uuid="498e94f1-ebea-4bff-bd39-0e4e3168d239"/>
<global_property property="radiology.radiologyCareSetting" property_value="6f0c9a92-6f24-11e3-af88-005056821db0" uuid="a3209d7c-ae4c-41a4-96de-876facd77226"/> <!--  set to uuid from CareSetting OUTPATIENT in openmrs core -->
<global_property property="radiology.radiologyOrderingProviderEncounterRole" property_value="13fc9b4a-49ed-429c-9dde-ca005b387a3d" description="Radiology Ordering Provider Encounter Role UUID"/>
<global_property property="radiology.radiologyOrderEncounterType" property_value="19db8c0d-3520-48f2-babd-77f2d450e5c7" description="Radiology Order Encounter Type UUID"/>
<global_property property="radiology.radiologyTestOrderType" property_value="dbdb9a9b-56ea-11e5-a47f-08002719a237" description="Radiology Test Order Type UUID"/>
<global_property property="radiology.nextAccessionNumberSeed" property_value="15" datatype="org.openmrs.customdatatype.datatype.RegexValidatedTextDatatype" datatype_config="^\d+$" uuid="f45d1722-d983-427b-82ed-c4e8beffd1c7"/>


<encounter_type encounter_type_id="1001" name="Radiology Order Encounter Type" description="Ordering radiology exams" creator="1" date_created="2015-09-09 00:00:00.0" retired="false" uuid="19db8c0d-3520-48f2-babd-77f2d450e5c7"/>
<encounter_role encounter_role_id="1001" name="Radiology Ordering Provider Encounter Role " description="Provider ordering tests, exams, drugs, ..." creator="1" retired="false" date_created="2015-09-09 14:00:00.0" uuid="13fc9b4a-49ed-429c-9dde-ca005b387a3d" />


  <!-- Provider for Radiology Orders -->

samuel34 · March 15, 2018, 2:16pm

Adding the global Properties to a dataSet a providing them with data makes stuff to workout
Thanks @ivange94