A gentle request to review some pull requests

Hi, a gentle request to help me look through this TRUNK-4954:ObsService.saveObs should throw a validation message if the obs and its encounter point to different persons by HerbertYiga · Pull Request #3646 · openmrs/openmrs-core · GitHub to see whether it still needs some work, plus some comments here IDGEN-122:Adding a validator for AutoGenerationOption by HerbertYiga · Pull Request #89 · openmrs/openmrs-module-idgen · GitHub and I do also have some comments on this that am kindly requesting help of RA-1714:Primary Diagnosis not being showed in the Encounter details by HerbertYiga · Pull Request #377 · openmrs/openmrs-module-coreapps · GitHub @mozzy @dkayiwa @ibacher @dev3 @dev4 @dev5

1 Like

Is first of all travis happy with your pull requests?

travis passes for the first two,while for the last one, it has changes that it depends on in core as seen here These changes are depended on by RA-1714 by HerbertYiga · Pull Request #3682 · openmrs/openmrs-core · GitHub

hi @dkayiwa these are the tickets that i raised up during the pm call,they are now two,for the third one i got comments.

ie https://github.com/openmrs/openmrs-core/pull/3646 and https://github.com/openmrs/openmrs-module-idgen/pull/89